Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reform internal use of template compiler #20587

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Reform internal use of template compiler #20587

merged 1 commit into from
Dec 11, 2023

Commits on Dec 2, 2023

  1. [CLEANUP canary] Reform internal use of template compiler 

    Previously, ember-source had a weird custom way of compiling templates
that appear within its own source. This PR makes it work the same way we
do everywhere else, using babele-plugin-ember-template-compilation.

This required solving a boostrapping problem: the babel plugin needs
ember-template-compiler.js, our build produces
ember-template-compiler.js, but our build wants to use the babel plugin.
I solved it by making the template compiler directly evaluatable in
node, with no build at all.

The *full* legacy ember-template-compiler API has a lot of silly things
shoved into it (like a reexport of all of the `Ember` metapackage), and
that was inextricably circular, so I introduced
`ember-template-compiler/minimal` for this internal use case.
    @ef4
    ef4 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    b4ab87b View commit details
    Browse the repository at this point in the history