Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-cli-babel #20681

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Update ember-cli-babel #20681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"unlink:all": "node bin/unlink-all.mjs"
},
"dependencies": {
"@babel/core": "^7.24.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to forward the peer to consumers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a choice. We can either have it in dependencies or in peerDependencies. In dependencies is more conservative and non-breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The path forward to getting rid of all this is when it's a v2 addon it won't try to bring any babel shenanigans at all.)

"@babel/helper-module-imports": "^7.16.7",
"@ember/edition-utils": "^1.2.0",
"@glimmer/compiler": "0.92.0",
Expand Down Expand Up @@ -88,7 +89,7 @@
"broccoli-merge-trees": "^4.2.0",
"chalk": "^4.0.0",
"ember-auto-import": "^2.6.3",
"ember-cli-babel": "^7.26.11",
"ember-cli-babel": "^8.2.0",
"ember-cli-get-component-path-option": "^1.0.0",
"ember-cli-is-package-missing": "^1.0.0",
"ember-cli-normalize-entity-name": "^1.0.0",
Expand All @@ -106,7 +107,6 @@
},
"devDependencies": {
"@aws-sdk/client-s3": "^3.321.1",
"@babel/core": "^7.22.9",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-decorators": "^7.23.6",
"@babel/plugin-transform-typescript": "^7.22.9",
Expand Down
Loading
Loading