Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation links for template-action & component-template-resolving #20700

Merged
merged 2 commits into from
May 24, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented May 22, 2024

@NullVoxPopuli
Copy link
Contributor

Thanks for submitting a pr to fix the links!

There are id links for each deprecation, which is important for not dealing with large pages, and losing scroll, etc.

I've left a comment with the actual urls for each - if you could update those, that'd be fantastic!

@ef4 ef4 merged commit 199218e into emberjs:main May 24, 2024
26 checks passed
@mkszepp mkszepp deleted the fix-deprecation-links branch May 24, 2024 19:32
@kategengler
Copy link
Member

I actually think this was a mistake when we merged into the deprecation-app -- the files added there should have been named without deprecate in the filename to match the ids of the deprecations. Am I correct @mansona ?

kategengler added a commit that referenced this pull request Jun 3, 2024
kategengler added a commit that referenced this pull request Jun 4, 2024
Revert "Merge pull request #20700 from mkszepp/fix-deprecation-links"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants