Update tagging strategy #20753
Update tagging strategy #20753
Conversation
This is preparation to make it possible to have more than one published package living in this monorepo. It changes the tagging strategy so that releases of ember-source should be tagged like `v6.0.0-ember-source` instead of `v6.0.0`.
| @@ -126,7 +126,7 @@ jobs: | |||
| run: pnpm vite build --mode=development | |||
|
|
|||
| - name: Set BrowserStack Local Identifier | |||
| if: startsWith(github.ref, 'refs/tags/v') | |||
| if: startsWith(github.ref, 'refs/tags/v') && endsWith(github.ref, '-ember-source') | |||
There was a problem hiding this comment.
Apparently you still cannot comment on unchanged lines on github:
Do we want to run this workflow at all for changes and or tags of @glimmer/component?
There was a problem hiding this comment.
Yes. The CI workflow is good test coverage for everything together, including @glimmer/component.
With #20751 we'll actually get better integration test coverage of @glimmer/component than we've ever had.
There was a problem hiding this comment.
Looking at this again, I think this is wrong -- the BrowserStack Local Identifier needs to be set on any tag, not just ember-source tags, if we're still running the BrowserStack jobs
|
I PR'd with a more comprehensive update to RELEASE.md #20754 The only other concern I have is that PRs for @glimmer/component will show up in the changelog via script for |
Update RELEASE.md
Co-authored-by: Katie Gengler <[email protected]>
This is preparation to make it possible to have more than one published package living in this monorepo.
It changes the tagging strategy so that releases of ember-source should be tagged like
v6.0.0-ember-sourceinstead ofv6.0.0.