Calling router.map now appends the routes instead of replacing them #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would have added a test but there did not seem to be any route generation tests.
|
Duplicate of #2485 ? |
|
Heh, seems like it, missed it. Though I think this code looks simpler? |
|
Thx, I read through the discussion. |
…imes without the map being overwritten. Allows routes to be added at runtime. One test with multiple cases also added. Conflicts: packages/ember-routing/lib/system/router.js
|
@stefanpenner @machty should be ready now |
stefanpenner
added a commit
that referenced
this pull request
Jun 26, 2013
Calling router.map now appends the routes instead of replacing them
|
👍 |
|
This seems to be no longer working in 1.11.1 and 1.12.0-beta 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have added a test but there did not seem to be any route
generation tests.