Use Ember.lookup as context for {{CONSTANT}}. Fixes #3098 #3218
Conversation
|
@xtian Can you update this to follow the guidelines here: http://emberjs.com/guides/contributing/adding-new-features/? |
|
@xtian this looks good to me, do you mind following the adding-new-features guideline peter suggested? Although this does seem like a bugfix, we will likely treat it as a new feature. |
|
Whoops, I forgot about this. Yep, I'll do that now. |
|
@xtian thanks dude. |
|
@stefanpenner should this be flagged too? It's sort of an odd case. |
|
@stefanpenner I think this is ready now |
|
@xtian this doesn't merge cleanly. Can you rebase on master? |
…r {{CONSTANT}}. Fixes emberjs#3098
|
@wagenet Rebased |
|
@wagenet ping |
|
Merged fc4df51. |
|
Thanks for your work on this PR, but this was no-go'd by the core team and will need to be reverted. The behavior we want is for this to always be a local path lookup. We're deprecating the global lookup. Since this would be a breaking change, in the meantime, we'd like to default to local path lookup and then fallback to global path lookup with a deprecation warning. @xtian Would you mind resubmitting a PR matching this behavior? |
|
@ebryn Sure, I'll take a look at that. So I should just remove this feature flag entirely, right? |
|
The behavior I described wouldn't need a feature flag, it would be considered a bugfix. |
|
@xtian Do you think you will have time to work on a PR for this next week? If not, we can find someone to hand it off to so we can get this all shipped. Thanks! |
|
@tomdale Yep, I'm looking at it right now. Sorry, this week ended up being busier for me than I anticipated. |
…lookups. Conflicts: features.json
This fixes the discrepancy in context between
{{CONSTANT}}and{{#each CONSTANT}}{{this}}{{/each}}as described in #3098.Is this the right way to fix this? I'm not sure if this change has unintended consequences.