Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

RFC #0287 - Tracking for Promote {{-in-element}} to public API #25

Closed
6 of 7 tasks
kategengler opened this issue Feb 12, 2019 · 6 comments
Closed
6 of 7 tasks

RFC #0287 - Tracking for Promote {{-in-element}} to public API #25

kategengler opened this issue Feb 12, 2019 · 6 comments
Assignees
Labels
team:ember.js ember.js team

Comments

@kategengler
Copy link
Member

kategengler commented Feb 12, 2019

RFC #0287 - Tracking for Promote {{-in-element}} to public API

Champion: @rwjblue


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

Ember.js Team:

glimmer-vm

ember.js

  • upgrade glimmer-vm dependency
  • document API
  • release

Ember CLI Team:

N/A

Ember Data Team:

N/A

Learning Team:

ember.js

guides-source

addon ecosystem

Steering Committee:

N/A

@kategengler kategengler added the team:ember.js ember.js team label Feb 22, 2019
@rwjblue rwjblue added needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee and removed needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee labels Apr 30, 2019
@MelSumner MelSumner removed the needs planning:learning Needs planning by the learning team label May 6, 2019
@simonihmig
Copy link

For the record: https://github.com/kaliber5/ember-in-element-polyfill has been updated to include the semantic change of the RFC as of v0.2.0, and should work as a polyfill going back to Ember 2.12!

@mansona
Copy link
Member

mansona commented Mar 16, 2020

I've done a bit of digging and it looks like the change was made to glimmer-vm in glimmerjs/glimmer-vm@22d1ea9 which was then released in [email protected] 🤔

As the glimmer-vm was updated past v0.40.0 in emberjs/ember.js@ade8188 does that mean that the public {{in-element}} API is available from Ember v3.18?

@simonihmig
Copy link

simonihmig commented Mar 16, 2020

@mansona my understanding is that though GlimmerVM has indeed been updated, and features all what is necessary to expose a public in-element, this has not been done yet on the side of Ember. See:

Though I am also curious what is preventing us from doing the necessary updates on Ember's side to make in-element public? /cc @rwjblue @chancancode

If it's "just" time to work on it, that I could try it...

@simonihmig
Copy link

A few points can be checked off here:

@locks
Copy link
Contributor

locks commented Apr 25, 2020

It has been enabled in canary via emberjs/ember.js#18927.

@sandstrom
Copy link

sandstrom commented Oct 13, 2020

Regarding the "addon ecosystem" todo above I've submitted two PRs. Maybe that's enough to tick that box here? Still up to them to decide, but at least we've pinged them now.

@locks locks closed this as completed May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team:ember.js ember.js team
Projects
None yet
Development

No branches or pull requests

7 participants