-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE | BREAKING] Change semantics of in-element to match emberjs/rfcs#287 #918
Merged
+81
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
impl-in-element-api
branch
2 times, most recently
from
February 11, 2019 17:12
3ec8da9
to
daee9a5
Compare
chadhietala
force-pushed
the
impl-in-element-api
branch
from
February 21, 2019 14:15
daee9a5
to
5a8e41d
Compare
chadhietala
force-pushed
the
impl-in-element-api
branch
2 times, most recently
from
February 22, 2019 03:26
25b6fce
to
7e291d3
Compare
rwjblue
reviewed
Mar 12, 2019
chadhietala
force-pushed
the
impl-in-element-api
branch
from
March 12, 2019 17:56
7e291d3
to
cbffc65
Compare
I think I have a few recommendations:
|
- Remove nextSibling in favor of insertBefore - Change semantics of insertBefore to always clear the remote element before inserting
chadhietala
force-pushed
the
impl-in-element-api
branch
from
March 29, 2019 18:20
cbffc65
to
22d1ea9
Compare
I added the test. We can do a refactor in the future to break apart the clearing out the target. I had some questions about the Enum map for operations since it has dups in it. |
chiragpat
added a commit
to chiragpat/glimmer-vm
that referenced
this pull request
Apr 10, 2019
- This is a slight modification of the changes introduced in PR glimmerjs#918, to continue to allow passing non null values to the insertBefore param of the in-element helper
chiragpat
added a commit
to chiragpat/glimmer-vm
that referenced
this pull request
Apr 10, 2019
- This is a slight modification of the changes introduced in PR glimmerjs#918, to continue to allow passing non null values to the insertBefore param of the in-element helper
chiragpat
added a commit
to chiragpat/glimmer-vm
that referenced
this pull request
Apr 10, 2019
- This is a slight modification of the changes introduced in PR glimmerjs#918, to continue to allow passing non null values to the insertBefore param of the in-element helper
chiragpat
added a commit
to chiragpat/glimmer-vm
that referenced
this pull request
Apr 10, 2019
- This is a slight modification of the changes introduced in PR glimmerjs#918, to continue to allow passing non null values to the insertBefore param of the in-element helper
chiragpat
added a commit
to chiragpat/glimmer-vm
that referenced
this pull request
Apr 10, 2019
- This is a slight modification of the changes introduced in PR glimmerjs#918, to continue to allow passing non null values to the insertBefore param of the in-element helper
7 tasks
rwjblue
changed the title
[FEATURE | BREAKING] Change semantics of in-element
[FEATURE | BREAKING] Change semantics of in-element to match emberjs/rfcs#287
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the clearing semantics of
in-element
as it pertains to emberjs/rfcs#287. Instead of appending we need to clear the contents of the destination element unlessinsertBefore
was explicitly set tonull
.This is required work for emberjs/rfcs#418