-
-
Notifications
You must be signed in to change notification settings - Fork 408
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into advance-rfc-0659
- Loading branch information
Showing
53 changed files
with
5,029 additions
and
179 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| <!-- If you are proposing a new RFC, please fill out the below template. | ||
| If not, please remove the below contents | ||
| --> | ||
|
|
||
| # Propose {{RFC_NAME}} | ||
|
|
||
| <!-- Update the below to link to the rendered version of your RFC. | ||
| The URL can be interpolated below or can be found by going to the files tab | ||
| and choosing `View file' from the `...' menu in the right hand corner of the file. --> | ||
|
|
||
| ## [Rendered](https://github.com/{{username}}/rfcs/blob/{{branch}}/text/{{rfc_number}}-{{rfc_slug}}.md) | ||
|
|
||
| ## Summary | ||
|
|
||
| This pull request is proposing a new RFC. | ||
|
|
||
| To succeed, it will need to pass into the [Exploring Stage](https://github.com/emberjs/rfcs#exploring)), followed by the [Accepted Stage](https://github.com/emberjs/rfcs#accepted). | ||
|
|
||
| A Proposed or Exploring RFC may also move to the [Closed Stage](https://github.com/emberjs/rfcs#closed) if it is withdrawn by the author or if it is rejected by the Ember team. This requires an "FCP to Close" period. | ||
|
|
||
| **An FCP is required before merging this PR to advance to Accepted.** | ||
|
|
||
| Upon merging this PR, automation will open a draft PR for this RFC to move to the [Ready for Released Stage](https://github.com/emberjs/rfcs#ready-for-release). | ||
|
|
||
| <details> | ||
| <summary>Exploring Stage Description</summary> | ||
|
|
||
| This stage is entered when the Ember team believes the concept described in the RFC should be pursued, but the RFC may still need some more work, discussion, answers to open questions, and/or a champion before it can move to the next stage. | ||
|
|
||
| An RFC is moved into Exploring with consensus of the relevant teams. The relevant team expects to spend time helping to refine the proposal. The RFC remains a PR and will have an `Exploring` label applied. | ||
|
|
||
| An Exploring RFC that is successfully completed can move to [Accepted](https://github.com/emberjs/rfcs#accepted) with an FCP is required as in the existing process. It may also be moved to [Closed](https://github.com/emberjs/rfcs#closed) with an FCP. | ||
| </details> | ||
|
|
||
| <details> | ||
| <summary>Accepted Stage Description</summary> | ||
|
|
||
| To move into the "accepted stage" the RFC must have complete prose and have successfully passed through an "FCP to Accept" period in which the community has weighed in and consensus has been achieved on the direction. The relevant teams believe that the proposal is well-specified and ready for implementation. The RFC has a champion within one of the relevant teams. | ||
|
|
||
| If there are unanswered questions, we have outlined them and expect that they will be answered before [Ready for Release](https://github.com/emberjs/rfcs#ready-for-release). | ||
|
|
||
| When the RFC is accepted, the PR will be merged, and automation will open a new PR to move the RFC to the [Ready for Release](https://github.com/emberjs/rfcs#ready-for-release) stage. That PR should be used to track implementation progress and gain consensus to move to the next stage. | ||
|
|
||
| </details> | ||
|
|
||
| ## Checklist to move to Exploring | ||
|
|
||
| - [ ] The team believes the concepts described in the RFC should be pursued. | ||
| - [ ] The label `S-Proposed` is removed from the PR and the label `S-Exploring` is added. | ||
| - [ ] The Ember team is willing to work on the proposal to get it to Accepted | ||
|
|
||
| ## Checklist to move to Accepted | ||
|
|
||
| - [ ] This PR has had the `Final Comment Period` label has been added to start the FCP | ||
| - [ ] The RFC is announced in #news-and-announcements in the Ember Discord. | ||
| - [ ] The RFC has complete prose, is well-specified and ready for implementation. | ||
| - [ ] All sections of the RFC are filled out. | ||
| - [ ] Any unanswered questions are outlined and expected to be answered before Ready for Release. | ||
| - [ ] "How we teach this?" is sufficiently filled out. | ||
| - [ ] The RFC has a champion within one of the relevant teams. | ||
| - [ ] The RFC has consensus after the FCP period. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,48 +28,51 @@ jobs: | |
|
|
||
| - name: Update frontmatter | ||
| run: | | ||
| node rfcs-tooling/update-rfc-stage.js ${{ inputs.new-stage }} ${{ inputs.rfc-path }} | ||
| node rfcs-tooling/scripts/update-rfc-stage.mjs ${{ inputs.new-stage }} ${{ inputs.rfc-path }} | ||
| - name: Set variables for use in PR | ||
| id: pr-variables | ||
| run: | | ||
| frontmatter=`node rfcs-tooling/rfc-frontmatter.js ${{ inputs.rfc-path }}` | ||
| frontmatter=`node rfcs-tooling/scripts/rfc-frontmatter.mjs ${{ inputs.rfc-path }}` | ||
| ready_for_release_pr=`echo $frontmatter | jq '.prs."ready-for-release"'` | ||
| ready_for_release_pr=${ready_for_release_pr//\"/} | ||
| released_pr=`echo $frontmatter | jq '.prs.released'` | ||
| released_pr=${released_pr//\"/} | ||
| rendered_rfc_url="https://github.com/$GITHUB_REPOSITORY/blob/advance-rfc-${{ inputs.rfc-number }}/${{ inputs.rfc-path }}" | ||
| title=`echo $frontmatter | jq '.title'` | ||
| if [[ ${{ inputs.new-stage }} == "ready-for-release" ]]; then | ||
| pretty_stage="Ready for Release" | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' .github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md` | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' -e "s>__RFC_RENDERED_URL__>$rendered_rfc_url>g" .github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md` | ||
| elif [[ ${{ inputs.new-stage }} == "released" ]]; then | ||
| pretty_stage="Released" | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' -e "s>__READY_FOR_RELEASE_PR__>$ready_for_release_pr>g" .github/PULL_REQUEST_TEMPLATE/advance-to-released.md` | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' -e "s>__READY_FOR_RELEASE_PR__>$ready_for_release_pr>g" -e "s>__RFC_RENDERED_URL__>$rendered_rfc_url>g" .github/PULL_REQUEST_TEMPLATE/advance-to-released.md` | ||
| elif [[ ${{ inputs.new-stage }} == "recommended" ]]; then | ||
| pretty_stage="Recommended" | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' -e "s>__READY_FOR_RELEASE_PR__>$ready_for_release_pr>g" -e "s>__RELEASED_PR__>$released_pr>g" .github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md` | ||
| template=`sed -e 's/__RFC_NUMBER__/${{ inputs.rfc-number }}/g' -e "s>__READY_FOR_RELEASE_PR__>$ready_for_release_pr>g" -e "s>__RELEASED_PR__>$released_pr>g" -e "s>__RFC_RENDERED_URL__>$rendered_rfc_url>g" .github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md` | ||
| fi | ||
| echo 'body<<EOF' >> $GITHUB_OUTPUT | ||
| echo "$template" >> $GITHUB_OUTPUT | ||
| echo 'EOF' >> $GITHUB_OUTPUT | ||
| echo "Pretty Stage: $pretty_stage" | ||
| echo "pretty-stage=$pretty_stage" >> $GITHUB_OUTPUT | ||
| echo "title=$title" >> $GITHUB_OUTPUT | ||
| - name: Open PR | ||
| id: create-pr | ||
| uses: peter-evans/[email protected] | ||
| with: | ||
| token: ${{ secrets.personal-access-token }} | ||
| commit-message: "Advance RFC to Stage ${{ inputs.new-stage }}" | ||
| commit-message: "Advance RFC ${{ inputs.rfc-number }} to Stage ${{ inputs.new-stage }}" | ||
| add-paths: 'text' | ||
| branch: "advance-rfc-${{ inputs.rfc-number }}" | ||
| title: "Advance RFC #${{ inputs.rfc-number}} to Stage ${{ steps.pr-variables.outputs.pretty-stage }}" | ||
| title: "Advance RFC #${{ inputs.rfc-number}} `${{ steps.pr-variables.outputs.title }}` to Stage ${{ steps.pr-variables.outputs.pretty-stage }}" | ||
| body: "${{ steps.pr-variables.outputs.body }}" | ||
| labels: "RFC Advancement,S-${{ steps.pr-variables.outputs.pretty-stage}}" | ||
| draft: true | ||
|
|
||
| - name: Add new PR link to RFC frontmatter | ||
| run: | | ||
| node rfcs-tooling/update-advancement-pr.js ${{ inputs.rfc-path }} ${{ inputs.new-stage}} ${{ steps.create-pr.outputs.pull-request-url }} | ||
| node rfcs-tooling/scripts/update-advancement-pr.mjs ${{ inputs.rfc-path }} ${{ inputs.new-stage}} ${{ steps.create-pr.outputs.pull-request-url }} | ||
| - name: Update PR | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.