RFC doc for adding uniqBy to enumerable #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this proposed to support the efforts in emberjs/ember.js#12875? |
|
Ah, it is now! I snooped around for an RFC for it and didn't find any either pending or accepted, so I thought I would submit my own. I didn't think to look at the open PRs as I thought, as an api change, it would require an RFC before implementation. Sorry about that! |
|
No apologies, you are absolutely right! I think this RFC applies to that PR very well. |
|
I'll update the rfc to remove the specifics to the enumerable mixin! |
| for (var i = 0; i < uniqKeys.length; i++) { | ||
| var key = uniqKeys[i]; | ||
|
|
||
| options = options.filter(iter.apply(options, [key, item[key]])); |
There was a problem hiding this comment.
is this supposed to be get(item, key)?
There was a problem hiding this comment.
Yes, it is! I'll update it in a bit.
|
This seems reasonable, we should discuss at the next meeting. |
|
This is already in ember, we should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.