Remove Ember.Map, Ember.MapWithDefault and Ember.OrderedSet

[Serabe]

rendered

[stefanpenner]

what are the details on how ember-data will work, and how we can be backwards compat with ED. It's possible, but that needs to be fleshed out in this RFV

[buschtoens]

If that is in the scope of this RFC, it might be worthwhile to take a look at switching to the native ES6 Map. The MapWithDefault behavior can be easily achieved: Babel REPL PoC

I would be available for such a PR in Ember Data. 🙋‍♂️

[locks]

@buschtoens I don't think it is. Switching to native Map seems like a big undertaking, especially if we are to support IE9 and family :P

[jrjohnson]

👍 for this option. I recall the last time something in heavy use in Ember Data was deprecated I was hit with a terrifying number of notices that I could do nothing about. While methods now exist to hep with this it should still be avoided if possible.

[rwjblue]

I'd like to see this one start to gain traction now that 3.0 is "out the door".

@Serabe - Thanks for the recent round of updates! I think the task list in the transition path looks pretty close to what I was thinking, but I'd like to make it clearer that the deprecation would only be landed once a released version of ember-data that included the fixes (to prevent the deprecation) shipped. Do you think that is clear enough in the current prose?

[rwjblue]

Changes landed in ember-data to remove direct usage of these classes:

• [BUGFIX beta] Use @ember/ordered-set to avoid deprecations. data#5372 - Migrates ember-data to use the @ember/ordered-set addon (instead of relying on Ember.OrderedSet)
• [BUGFIX beta] Use native Map if present. data#5255 - Migrates to using native Map, and removes any Ember Data usage of Ember.Map or Ember.MapWithDefault.

Both of those PR's should wind up included in [email protected].

[rwjblue]

Just discussed this with the rest of the core team, and with the recent round of changes and the work in ember-data to detangle from these classes we think this is ready for final comment period.

addressed concerns

[rwjblue]

Lets do it!