RFC to collocate tests in in-repo-addons #378
Conversation
|
I'm assuming that in-repo lazy engines would be covered under this? We might need to specify that by default the in-repo tests would use the |
|
I would very much love to see the inclusion of having a dummy app as mentioned in the "Unresolved questions" section. |
|
@luketheobscure Could you expand? I will make it a little clearer in the RFC that only the location of the test source code will change. The built assets will remain identical to the non-collated version. |
|
@jeanduplessis I will try and get that RFC up as soon as possible. I'm intentionally keeping them separate as I have the code to make this RFC happen, but there is a lot of discussion that will go into the idea of separating the test output into separate bundles or having dummy apps in the in-repo-engines. Although that is certainly the end goal and the bit I am most excited to see happen! |
Add point about test dist output remaining the same.
|
Should this RFC be in https://github.com/ember-cli/rfcs ? |
|
See also ember-cli/rfcs#60 |
I heard that ember-cli/rfcs might be deprecated soon. I was going to inquire if I should still move this to ember-cli, but after a recent write up, should we just leave it here? |
| - use `includeTestsInHost: true` in `index.js` to indicate collocated tests | ||
| - Implement CLI flag that only runs the tests for a specified addon | ||
| - `ember test --ir-addon foo-bar` | ||
| - The flag's use would create a list of tests to run that are collocated in that in-repo-addon's test folder. The tests will still be included all in one bundle, so this is basically just running the modules that are associated with the co-located tests. |
There was a problem hiding this comment.
Since all the test are included into a single bundle why do we need --ir-addon flag? Build takes a while, building several --ir tests may be annoying.
What if we provide something like "Engines" or "Bundles" dropdown in qunit interface?
|
Given the inactivity here I'm going to go ahead and close this. I apologize for the fact that this stagnated and if you would still like to try to move this forward, let me know and I'll ensure that it gets a proper review. |
Rendered