Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring addon modules in Module Unification layout #462

Closed
wants to merge 4 commits into from

Conversation

ppcano
Copy link

@ppcano ppcano commented Mar 10, 2019

@mixonic
Copy link
Member

mixonic commented Oct 21, 2019

@ppcano Thanks for the thought on this!

As you may already be aware in https://blog.emberjs.com/2019/03/11/update-on-module-unification-and-octane.html and #367 (comment) the module unification design was largely set aside in favor of designs which layer more transparently on the ES modules system. This means most of the implementation details, even those lacking design like the addon modules configuration API, are effectively dead ends.

With that in mind (and after raising this with framework core at https://github.com/emberjs/core-notes/blob/master/ember.js/2019-09/Meeting_Ember_Core_Team_20190920.md) I'm going to flag this RFC as FCP to close. I appreciate the time you put in here, and it would be great to work with you an another contribution or design.

@mixonic mixonic added the FCP to close The core-team that owns this RFC has moved that this RFC be closed. label Oct 21, 2019
@rwjblue rwjblue closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FCP to close The core-team that owns this RFC has moved that this RFC be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants