-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move HTTP Mock to addon #576
Conversation
This seems reasonable to me. I'll see what I can do to get it moving. |
I've added this RFC to next week's agenda. |
We discussed this at the CLI meeting today. We think is a good path forward and are open to accepting if there is someone volunteering to move it forward. |
Moving to an addon seems great if doable; however, it would be better if we exposed a serverMiddleware hook directly to ember apps for this purpose. The dance otherwise is very complicated and not forward-thinking as we move away from older addon patterns. I'd like to see http-mocks be the default story, mirage is .... not an ideal solution for anyone. |
@runspired could you expand on this a bit. I'm guessing you'd suggest an ember-cli RFC for this change? |
@wagenet currently to implement anything as a server-middleware it must be created as an addon. EmberCLI has no ability currently for sever middleware to be added except that mechanism. This makes creating solutions for apps that hook into the serve process very complicated: which includes any proposed http-mock replacement. Instead of mocks in-app you end up with mocks in an addon in the app. |
Basically my suggestion is for embercli to add registerMiddleware to the EmberApp in ember-cli-build |
We think the medium-term plan should be to deprecate HTTP mock, rather than extract it. To that end, we are putting this in FCP to close. |
rendered