Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend RFC #671 #720

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Amend RFC #671 #720

merged 2 commits into from
Feb 9, 2021

Conversation

chancancode
Copy link
Member

  1. Include TargetActionSupport mixin in the list.
  2. Clarify that the private mixins are not included in the legacy addon.

@chancancode
Amend RFC #671
75612dd 
1. Include `TargetActionSupport` mixin in the list.
2. Clarify that the private mixins are not included in the legacy
   addon.
rwjblue
rwjblue approved these changes Feb 9, 2021
View reviewed changes
text/0671-modernize-built-in-components-1.md Outdated Show resolved Hide resolved
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 9, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
dc214b7 
Implements emberjs/rfcs#720

Part of #19270
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 9, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
3d74fde 
Implements emberjs/rfcs#720

Part of #19270
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 9, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
c79bf85 
Implements emberjs/rfcs#720

Part of #19270
@rwjblue rwjblue merged commit 72e468b into master Feb 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the modernizing-built-in-components-amend branch February 9, 2021 12:30
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 11, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
97d90ce 
Implements emberjs/rfcs#720

Part of #19270
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 13, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
911e32f 
Implements emberjs/rfcs#720

Part of #19270
chancancode added a commit to emberjs/ember.js that referenced this pull request Feb 25, 2021
@chancancode
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
d854377 
Implements emberjs/rfcs#720

Part of #19270
sly7-7 pushed a commit to sly7-7/ember.js that referenced this pull request Mar 10, 2021
@chancancode @sly7-7
[FEATURE modernized-built-in-components] Deprecate TargetActionSupport
481fa68 
Implements emberjs/rfcs#720

Part of emberjs#19270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chancancode @rwjblue @locks