-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advance RFC #0812 "Add tracked-built-ins"
to Stage Recommended
#943
Conversation
@locks are you still planning to be able to prioritize this? I think the next action is to figure out the remaining TODO list. |
@ef4 I got sidetracked with some other work. I'll have an update for next week's meeting. |
Added criteria around interop with observers and computed. @runspired is interested in working toward that. |
If nobody wants to work on the interop improvements imminently I'm in favor of moving this to recommended without it. |
Regarding the interop concerns, there is a fork of tracked-built-ins here which has interop support for TrackedObject with the classic reactivity system. @dgeb and @wycats created it for us back in 2022, and it's been working great for us in Discourse since then. IIRC at the time there was some resistance to adding compat support to the official version, hence why this ended up as a fork. Not sure of the details there. I assume the compat process used there for TrackedObject could be extended to the other interfaces as well 🤞 |
The next action here is bringing the fork up to date and getting it ready as a PR to tracked-built-ins. |
Status: Interop still is not being actively worked on. In addition, we don't have guides content and probably should. Arguably we should ship guides regardless and could decide to punt on the extra interop, given that tracked-built-ins has been in the default blueprint already for quite a while. |
An example of where guides content could go (while also removing the use of deprecated array prototype extensions): https://guides.emberjs.com/v5.8.0/in-depth-topics/autotracking-in-depth/#toc_arrays |
Ongoing progress on docs ember-learn/guides-source#2054 |
We have now completed the planned docs work, I'm suggesting this is ready to go, the extra interop work isn't something anyone has picked up, it could still happen when somebody chooses to do it. |
Advance #812 to the Recommended Stage
Summary
This pull request is advancing the RFC to the Recommended Stage.
tracked-built-ins
dependency #812An FCP is required before merging this PR to advance.
Recommended Stage Summary
The "Recommended" stage is the final milestone for an RFC. It provides a signal to the wider community to indicate that a feature has been put through its ecosystem paces and is ready to use.
To reach the "Recommended" stage, the following should be true:
If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
If the proposal updates or replaces an existing feature, high-quality codemods are available.
If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.
Checklist to move to Recommended
Final Comment Period
label has been added to start the FCP.Criteria for moving to Recommended (required)
<-- Copy and paste the criteria for "Recommended" from the Ready For Release stage here -->
A set of criteria for moving this RFC to the Recommended Stage, following release:
@tracked
does.