Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend browser support policy for Safari #984

Merged
merged 11 commits into from
Feb 7, 2024
95 changes: 95 additions & 0 deletions text/0984-drop-safari-less-than-14.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
---
achambers marked this conversation as resolved.
Show resolved Hide resolved
stage: accepted
start-date: 2023-11-02T15:40:00.000Z
release-date: # In format YYYY-MM-DDT00:00:00.000Z
release-versions:
teams: # delete teams that aren't relevant
- cli
- data
- framework
- learning
- steering
- typescript
prs:
accepted: https://github.com/emberjs/rfcs/pull/984
project-link:
suite:
---


<!---
Directions for above:

stage: Leave as is
start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z
release-date: Leave as is
release-versions: Leave as is
teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies
prs:
accepted: Fill this in with the URL for the Proposal RFC PR
project-link: Leave as is
suite: Leave as is
-->

# Drop support for Safari < v14.1

## Summary
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved

Until v14.1, Safari doesn't support:
- private class fields: https://caniuse.com/mdn-javascript_classes_private_class_fields

Other features in the ecosystem,

class static initialization blocks:
- Safari 16.4: https://caniuse.com/mdn-javascript_classes_static_initialization_blocks

This RFC is not concernd with static initialization blocks, as those can easily by transpiled without adding a a lot of code.
achambers marked this conversation as resolved.
Show resolved Hide resolved

## Motivation

Private class field transpilation has a big impact on the kind of code emitted. We want to transpile as little as possible -- ideally nothing, and let app users decide if they need to transpile further.
achambers marked this conversation as resolved.
Show resolved Hide resolved

## Detailed design

Ember v6 Will not support Safari < v14.1
achambers marked this conversation as resolved.
Show resolved Hide resolved


> This is the bulk of the RFC.

> Explain the design in enough detail for somebody
familiar with the framework to understand, and for somebody familiar with the
implementation to implement. This should get into specifics and corner-cases,
and include examples of how the feature is used. Any new terminology should be
defined here.

## How we teach this

> What names and terminology work best for these concepts and why? How is this
idea best presented? As a continuation of existing Ember patterns, or as a
wholly new one?

> Would the acceptance of this proposal mean the Ember guides must be
re-organized or altered? Does it change how Ember is taught to new users
at any level?

> How should this feature be introduced and taught to existing Ember
users?

## Drawbacks

> Why should we *not* do this? Please consider the impact on teaching Ember,
on the integration of this feature with other existing and planned features,
on the impact of the API churn on existing apps, etc.

> There are tradeoffs to choosing any path, please attempt to identify them here.

## Alternatives

> What other designs have been considered? What is the impact of not doing this?

> This section could also include prior art, that is, how other frameworks in the same domain have solved this problem.

## Unresolved questions

> Optional, but suggested for first drafts. What parts of the design are still
TBD?
Loading