Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Section on missing docs #3584

Merged

Conversation

kennethlarsen
Copy link
Member

No description provided.

@kennethlarsen kennethlarsen requested a review from a team September 28, 2018 11:05
Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! ✨ I just left one minor comment on wording, otherwise this seems all good to 🍏

@@ -51,8 +51,10 @@ As always, **leave your comments** and appreciation [below the original proposal

---

## [SECTION TITLE](#section-url)
## [The Missing Docs Has Returned](https://github.com/emberjs/ember.js/pull/17002)
There has been [some documentation missing](https://github.com/emberjs/ember.js/issues/16993) from the Ember API docs from the release of 3.3 to 3.4. [@Gaurav0](https://github.com/Gaurav0) has done some great detective work 🕵 and [fixed these issues](https://github.com/emberjs/ember.js/pull/17002) which means that **the missing documentation now is back.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be

[...] means that **the missing documentation is back now.**

@kennethlarsen kennethlarsen merged commit 87d08dc into emberjs:blog/embertimes-66 Sep 28, 2018
@kennethlarsen kennethlarsen deleted the blog/embertimes-66 branch September 28, 2018 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants