Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Ember.js Framework Core Team F2f blog post #3776

Merged
merged 5 commits into from
Jan 26, 2019
Merged

Ember.js Framework Core Team F2f blog post #3776

merged 5 commits into from
Jan 26, 2019

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Jan 25, 2019

What it does

Adds a new blog post! This content was extensively reviewed by framework core team members while it was in a Dropbox doc, and just needs a quick check from someone with sharp eyes to make sure there are no typos.

It also adds hooks to .alexrc so that tests won't fail because of this very common word.

Changes from Dropbox:

  • gave it a title
  • instead of "framework core team," called it "Ember.js Core Team" to align with https://emberjs.com/teams
  • linked to teams in the first sentence
  • removed a sentence that said something is in FCP (it is now merged)
  • three months to go until EmberConf --> two months

@jenweber jenweber requested a review from mixonic January 25, 2019 04:24
Copy link
Member

@kennethlarsen kennethlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads great and I don't see any typos! ✨

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayjayjpg jayjayjpg mentioned this pull request Jan 25, 2019
13 tasks
@amyrlam amyrlam mentioned this pull request Jan 25, 2019
18 tasks
@jenweber jenweber merged commit 66abc10 into emberjs:master Jan 26, 2019
@locks
Copy link
Contributor

locks commented Jan 26, 2019

🎉 🎉 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants