This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Angle brackets and contributors for Ember Times #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: it seems safe to say "is coming soon" because https://guides.emberjs.com/release/components/block-params/ still reflects the old although ember-learn/guides-source#357 is merged (guessing the deployments for this repo are not automatic intentionally?) |
| --- | ||
|
|
||
| ## [SECTION TITLE](#section-url) | ||
| ## [Bringing Angle Brackets to the Guides 🥳](https://github.com/ember-learn/guides-source/issues/139) |
There was a problem hiding this comment.
Not sure if only on my laptop but the emoji is just a square for me?
There was a problem hiding this comment.
Thanks - it's the party "face" but maybe it's too new of an emoji, changed to the older 🎉
|
@amyrlam Yes it is intentional that it isn't deployed yet so I think saying "coming soon" is the right approach |
|
Thanks for confirming that @kennethlarsen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let me know if any feedback!