Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text for no results #94

Closed
wants to merge 2 commits into from
Closed

Add text for no results #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b99cc
Add text for no results
alexander-alvarez Oct 4, 2017
9f7c4ea
Making sure only runs when there is search query
alexander-alvarez Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/templates/components/large-search.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,7 @@
{{/search-result-set}}
{{else if search.isRunning}}
{{dot-spinner}}
{{else if (and search.performCount query.length)}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will erroneously show when a search has happened and a query has been typed, but it is not a valid query that triggers a search. Take a look at queryIsValid CP in app/components/large-search.js

<h4 class="result-info test-result-info">No results for "{{query}}"</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test- classes are meant to be unique, at least per route. test-result-info shouldn't be repeated here.

{{/if}}
</div>
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"ember-router-scroll": "~0.3.0",
"ember-sanitize": "^2.0.2",
"ember-source": "~2.14.1",
"ember-truth-helpers": "^1.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of truth-helpers. I prefer a local and helper so as not to make the rest of the helpers from truth-helpers available.

"emberx-select": "^3.1.0",
"glob": "^7.1.1",
"http-proxy": "^1.15.2",
Expand Down