Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
simonihmig committed Oct 18, 2022
1 parent 3f85dc4 commit f7b3c9c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
6 changes: 3 additions & 3 deletions files/__addonLocation__/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"devDependencies": {
"@babel/core": "^7.17.0",
<% if (typescript) { %>"@babel/preset-typescript": "7.18.6"<% } else { %>"@babel/eslint-parser": "^7.18.2"<% } %>,
<% if (typescript) { %>"@babel/preset-typescript": "^7.18.6"<% } else { %>"@babel/eslint-parser": "^7.18.2"<% } %>,
"@babel/plugin-proposal-class-properties": "^7.16.7",
"@babel/plugin-proposal-decorators": "^7.17.0",
"@babel/plugin-syntax-decorators": "^7.17.0",
Expand All @@ -56,8 +56,8 @@
"@types/ember__component": "^4.0.0",
"@types/ember__routing": "^4.0.0",
"@types/ember__test-helpers": "^2.6.1",
"@typescript-eslint/eslint-plugin": "5.30.5",
"@typescript-eslint/parser": "5.30.5",<% } else { %>
"@typescript-eslint/eslint-plugin": "^5.30.5",
"@typescript-eslint/parser": "^5.30.5",<% } else { %>
"@rollup/plugin-babel": "^5.3.0",<% } %>
"concurrently": "^7.2.1",
"ember-template-lint": "^4.0.0",
Expand Down
12 changes: 1 addition & 11 deletions files/__addonLocation__/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,10 @@
{
"extends": "@tsconfig/ember/tsconfig.json",
"compilerOptions": {
"paths": {
// No paths, no absolute imports, only node_modules imports allowed
// But fallback for type-overrides and such
"*": ["types/*"]
}
},
"include": [
"src/**/*",
"types/**/*"
],
"glint": {
"environment": "ember-loose",
"transform": {
"include": ["src/**"]
}
"environment": "ember-loose"
}
}
2 changes: 1 addition & 1 deletion tests/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe('ember addon <the addon> -b <this blueprint>', () => {
});

afterAll(async () => {
fs.rm(tmpDir, { recursive: true, force: true });
await fs.rm(tmpDir, { recursive: true, force: true });
});

it('was generated correctly', async () => {
Expand Down

0 comments on commit f7b3c9c

Please sign in to comment.