Add dependenciesMeta.*.injected: true to test-app #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
pnpm-injected-meta
branch
from
219a213
to
30f8b64
Compare
simonihmig
reviewed
Feb 15, 2023
| [addonInfo.name.dashed]: { | ||
| injected: true, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
This is never written back to the file, isn't it?
Also, we already have a place to extend the file here, maybe we can handle this in one place?
|
Would be good to have this indeed! Took me way too much time already figuring out hard to understand issues that seem to relate to this (see embroider-build/embroider#1332) |
|
I opened: pnpm/pnpm#6088 I'm nervous about this change because of the lack of automatic re-syncing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using peerDependencies, this is a required setting in order for dependency resolution to behave correctly.
For more information see: