Component compilation tests #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Jul 17, 2023
|
|
||
| let contents = await dirContents(distDir); | ||
| it('build and test ', async () => { |
There was a problem hiding this comment.
I took @mansona's idea of combining build and test from here: https://github.com/embroider-build/addon-blueprint/pull/152/files#diff-701470fca7065559632e890e1777c5a9d14e52147ffde95608aa3bce3362c581R102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests that various component scenarios are generated correctly by running tests in the test-app that use those components.
This will allow us to feel more comfortable with switching up the rollup config without worrying about breaking stuff in the future.
In an effort to keep PRs small, I've kept the number of tests added to a small amount, and will add more in follow up PRs.
I also adapted the default test setup to use the fixture helpers from a previous PR, so I didn't want to change too much at once
In particular, we need: