show test logs in CI #157
Open
show test logs in CI #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
previously approved these changes
Jul 17, 2023
NullVoxPopuli
previously approved these changes
Jul 17, 2023
| @@ -6,16 +7,16 @@ import { matchesFixture } from './assertions.js'; | |||
| import { copyFixture } from './fixtures.js'; | |||
| import { createAddon, createTmp, install, runScript } from './utils.js'; | |||
|
|
|||
| const DEBUG = process.env.DEBUG === 'true'; | |||
| const debugLog = debug('addon-blueprint:temp'); | |||
There was a problem hiding this comment.
temp feels like a goofy label
simonihmig
previously approved these changes
Jul 19, 2023
| import { type Options, execa } from 'execa'; | ||
| import fse from 'fs-extra'; | ||
| import fs from 'node:fs/promises'; | ||
| import os from 'node:os'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const DEBUG = process.env.DEBUG === 'true'; | ||
| const debugLog = debug('addon-blueprint:utils'); |
There was a problem hiding this comment.
addon-blueprint:test-utils maybe? To not suggest users they get debug output when running the bp itself, since this is only effective when running the bp's tests...
mansona
dismissed stale reviews from simonihmig and NullVoxPopuli
more work to be done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will give me more confidence which tests are actually being run in CI, especially since there is a lot of "skipped" tests in the output (because of the way that vitest works)