Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Babel all the things #225

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

pzuraq
Copy link

@pzuraq pzuraq commented Jun 27, 2019

Enables babel transpilation for ember-auto-import packages. Also adds the skipBabel configuration option, which allows users to skip babel transpilation for specific packages.

Copy link
Collaborator

@ef4 ef4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

function returnUndefined() {
// this should throw an error unless it's been transpiled
return foo;
let foo = 123;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, nice, I like this.

@ef4 ef4 merged commit 9f06682 into embroider-build:master Jun 28, 2019
@ef4 ef4 mentioned this pull request Jun 28, 2019
@pzuraq pzuraq deleted the babel-all-the-things branch June 28, 2019 22:12
@mnoble01
Copy link

mnoble01 commented Jul 2, 2019

@ef4 Do you have a rough idea of when this change will be released?

@ef4
Copy link
Collaborator

ef4 commented Jul 6, 2019

Published in 1.5.0. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants