Ensure chunk filenames are consistent for long-term caching #548
Conversation
Per https://webpack.js.org/configuration/output/#template-strings, `contenthash` is based on the final content of the chunk file. Given the same file contents, the filename is guaranteed to be the same. Resolves embroider-build#519
This commit works around a couple of issues in `ember-auto-import` which were causing non-deterministic chunk filenames and content. Deterministic output should improve cache-reusability across deploys. Refs: embroider-build/ember-auto-import#519 embroider-build/ember-auto-import#548 embroider-build/ember-auto-import#478
This commit works around a couple of issues in `ember-auto-import` which were causing non-deterministic chunk filenames and content. Deterministic output should improve cache-reusability across deploys. Refs: embroider-build/ember-auto-import#519 embroider-build/ember-auto-import#548 embroider-build/ember-auto-import#478
|
Thanks. Since I see you've already tried this in discourse, can you check if there's any impact on the development-time rebuild performance? Just asking because if it turns out to be more expensive, we can use it for prod but not dev. If the cost doesn't change, this PR will be fine as is and we can just always use it. |
|
Thanks for taking a look @ef4 We didn't notice any performance change, but I haven't done any statistically-significant measurements. I did note that Webpack only enables That said, after some more experimenting, I don't think this change is sufficient by itself. I've expanded a little in #519 (comment). We've ended up disabling auto-import sourcemaps in production for now to improve cross-build caching. I'm hopeful that #479 will help with the problem we're seeing. I think removing the ephemeral paths like |
Per https://webpack.js.org/configuration/output/#template-strings,
contenthashis based on the final content of the chunk file. Given the same file contents, the filename is guaranteed to be the same.Resolves #519