Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @ syntax in helpers #1008

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Oct 20, 2021

Adds support for "{{my-addon@thing}}"

@thoov thoov changed the title Adding failing test cases for helper "{{my-addon@thing}}" Support @ syntax for helpers Oct 20, 2021
@thoov thoov changed the title Support @ syntax for helpers Support @ syntax in helpers Oct 20, 2021
@thoov
Copy link
Collaborator Author

thoov commented Oct 20, 2021

cc: @rwjblue

@lifeart
Copy link
Collaborator

lifeart commented Oct 21, 2021

@thoov I'm wondering, could we have kinda plugin API for it, instead of having it in main codebase?

Batman syntax is not officially supported, and used only in linkedin as I know.

I believe all addons, using custom AST transforms for HBS will benefit on it.
68 addons could be able to use it to get embroider support

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 25, 2021

@lifeart - Most things that have AST plugins that can serialize back into HBS already work just fine. The issue with the batman syntax is that it can't serialize back into HBS.

@rwjblue rwjblue added the enhancement New feature or request label Oct 25, 2021
@rwjblue rwjblue merged commit ac17423 into embroider-build:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants