Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier to the list of built-ins #1154

Merged

Conversation

Windvis
Copy link
Collaborator

@Windvis Windvis commented Mar 7, 2022

Small follow-up of #1151. I forgot to uncomment that in the list 😄.

It could theoretically cause a Missing helper: modifier error if staticHelpers is enabled and no arguments are passed: {{(modifier)}} but that seems like a very weird thing to do, and the template compiler already catches this:

Assertion Failed: The modifier keyword requires at least one positional arguments

@ef4 ef4 merged commit 8ec7098 into embroider-build:main Mar 8, 2022
@ef4 ef4 added the bug Something isn't working label Mar 8, 2022
@Windvis Windvis deleted the chore/uncomment-modifier-built-in branch March 29, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants