Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align webpack's outputPath with the whole app #1194

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Align webpack's outputPath with the whole app #1194

merged 2 commits into from
Apr 20, 2022

Commits on Apr 18, 2022

  1. Align webpack's outputPath with the whole app 

    We hard-code webpack's output path to be the "assets" subdirectory of the built app (which appears as "./dist/assets" after you run a build).

This is needlessly confusing and limiting, because webpack's view of the world doesn't match what the app author actually writes. Mostly this doesn't matter when people are using all the defaults, but if they wanted to customize (for example) the location of the generated chunks they can't escape the assets subdir.

This PR fixes this problem by setting webpack's `output.path` to the root of the (output) ember app (meaning the "./dist" subdir in a typical build), and making corresponding adjustments to `output.filename` and `output.chunkFileName` so that we're still producing the same files by default, but they're now addressed relative to the whole app.
    @ef4
    ef4 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    be0a460 View commit details
    Browse the repository at this point in the history

  2. more documentation on publicAssetURL

    @ef4
    ef4 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    bd7d960 View commit details
    Browse the repository at this point in the history