Strip extension from reexport of rollup-app-reexports
#1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `rollup-app-reexports` strip file extensions (`.js`) from reexports, aligning with (the blueprint of) v1 addons, and allowing better interoperability with `package.json#exports` with path mappings including extensions, as discussed in typed-ember/glint#338.
simonihmig
force-pushed
the
addon-dev-strip-extension
branch
from
1858166
to
96d92fa
Compare
simonihmig
commented
Jun 3, 2022
| source: `export { default } from "${pkg.name}/${addonFilename}";\n`, | ||
| source: `export { default } from "${pkg.name}/${addonFilename.slice( | ||
| 0, | ||
| -extname(addonFilename).length |
There was a problem hiding this comment.
I tried to not hardcode the .js extension here for whatever (stupid) reason, but thinking about it again that's probably useless, as a reexport can only refer to js files!?
|
Thanks @simonihmig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
rollup-app-reexportsstrip file extensions (.js) from reexports, aligning with (the blueprint of) v1 addons, and allowing better interoperability withpackage.json#exportswith path mappings including extensions, as discussed in typed-ember/glint#338.