Stabilize extensions for addon-dev's publicEntrypoints.

[NullVoxPopuli]

Per some discussion in #1099
(and some common questions in discord),
we want to use .js for all file paths in the rollup config.

This PR transparently adds every extension (we only support 5) to each glob passed to addon.publicEntrypoints so that we can only specify .js, regardless of what the filetypes are on disk.

I'm currently getting stuck on this error:

(!) The emitted file "components/demo/index.js" overwrites a previously emitted file of the same name.

which you can reproduce via:

cd tests/scenarios
yarn test:output --scenario v2-addon-dev-typescript
cd output
cd node_modules/v2-addon
node node_modules/rollup/dist/bin/rollup -c ./rollup.config.mjs

[ef4]

This is the right goal but the wrong implementation. Rewriting people's globs is going to be fraught with unexpected behaviors. Lots of legal glob patterns won't have the file extension in the final position, or will have a false match for the extension in non-final positions.

Instead this should work the same way the existing hbs support works, which is:

1. We run the users globs and a pattern for *.hbs.
2. If we get a match against *.hbs we take that specific filename and replace the .hbs with .js, and then test whether that resulting name matches one of the user's patterns.

The reason this is better than rewriting the globs is that it's much easier to change the extension on an exact filename than on an arbitrary glob pattern. Just to give you one example to illustrate the problem, consider: 'ember.js/*/+(component.js|example.js)'.

[NullVoxPopuli]

update -- I figured it out

---

where I'm failing is that I seem to somehow be removing ts files from the build entirely. they aren't transpiled by rollup-plugin-ts and the resulting ts+hbs co-located component ends up as a template-only component in dist

[NullVoxPopuli]

This is what I'm least certain about :-\

It feels like a hack, and I don't know if it's correct.

[NullVoxPopuli]

if I only do:

            this.emitFile({
              type: 'chunk',
              id: join(args.srcDir, name),
              fileName: normalizedName,
            });

then we get:

(!) The emitted file "components/demo/index.js" overwrites a previously emitted file of the same name.

and the resulting component ends up being a template-only component -- ie, the class is lost

[ef4]

I would guess the TS plugin is already emitting that JS file. But it probably shouldn't be. Perhaps it has options to control that?

For example, it might be trying to emit a JS file for every TS file, but that would be wrong. We only want to emit public entrypoints, and let other modules get rolled up.

[NullVoxPopuli]

Perhaps it has options to control that?

plugins can't interact with other plugins tho? or can they?

maybe I don't understand?

[ef4]

I mean the options you're passing directly to the ts plugin in the example config.

[NullVoxPopuli]

there are no options for passing entryPoints to the plugin? https://github.com/wessberg/rollup-plugin-ts

[nightire]

@NullVoxPopuli Hi, we use rollup-plugin-ts in a recent project and found it ditches the default types of generics in the output.

For example, for input like:

export interface Foo<T extends Bar | undefined = undefined> {
  ...
}

the output is:

export interface Foo <T extends Bar | undefined> {
  ...
}

So we end up to use rollup-plugin-typescript2 + rollup-plugin-dts instead. Just for your information, because this project is not an embroider project, we can not be sure if rollup-plugin-ts will be a problem here.

[NullVoxPopuli]

I think something else may have been at play in your project because rollup-plugin-ts very faithfully generates type definitions (I just confirmed just now by looking at the dists' d.ts files with default type args).