add inter-package version safety check #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that our release process isn't all lockstep, it's easy to get this wrong, so I'm just preempting adding a test for it.
Adopting code-equality-assertions so that we don't get burned by non-semantic changes in output formats. In order to adopt it, I had to upgrade jest because jest brings its own resolver (sigh) that didn't understand newer node `exports` in package.json. I had to use resolutions to deduplicate graceful-fs because jest pulled that in and it breaks support for `process.chdir` when there's more than one copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our release process isn't all lockstep, it's easy to get this wrong, so I'm just preemptively adding a test for it.