-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepping release #1470
Merged
Merged
Prepping release #1470
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,7 @@ | ||
| { | ||
| "solution": { | ||
| "@embroider/addon-dev": { | ||
| "impact": "patch", | ||
| "oldVersion": "3.1.0", | ||
| "newVersion": "3.1.1", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider/packages/addon-dev/package.json" | ||
| "oldVersion": "3.1.1" | ||
| }, | ||
| "@embroider/addon-shim": { | ||
| "oldVersion": "1.8.5" | ||
|
|
@@ -20,45 +11,53 @@ | |
| }, | ||
| "@embroider/compat": { | ||
| "impact": "patch", | ||
| "oldVersion": "3.0.0", | ||
| "newVersion": "3.0.1", | ||
| "oldVersion": "3.0.1", | ||
| "newVersion": "3.0.2", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Has dependency `workspace:*` on @embroider/macros" | ||
| }, | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider/packages/compat/package.json" | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider-main/packages/compat/package.json" | ||
| }, | ||
| "@embroider/core": { | ||
| "impact": "patch", | ||
| "oldVersion": "3.0.0", | ||
| "newVersion": "3.0.1", | ||
| "oldVersion": "3.0.1", | ||
| "newVersion": "3.0.2", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| }, | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Has dependency `workspace:*` on @embroider/macros" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider/packages/core/package.json" | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider-main/packages/core/package.json" | ||
| }, | ||
| "@embroider/hbs-loader": { | ||
| "oldVersion": "3.0.0" | ||
| }, | ||
| "@embroider/macros": { | ||
| "oldVersion": "1.11.0" | ||
| }, | ||
| "@embroider/router": { | ||
| "impact": "patch", | ||
| "oldVersion": "2.1.0", | ||
| "newVersion": "2.1.1", | ||
| "oldVersion": "1.11.0", | ||
| "newVersion": "1.11.1", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider/packages/router/package.json" | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider-main/packages/macros/package.json" | ||
| }, | ||
| "@embroider/router": { | ||
| "oldVersion": "2.1.1" | ||
| }, | ||
| "@embroider/shared-internals": { | ||
| "oldVersion": "2.1.0" | ||
|
|
@@ -67,20 +66,11 @@ | |
| "oldVersion": "3.0.1" | ||
| }, | ||
| "@embroider/util": { | ||
| "impact": "patch", | ||
| "oldVersion": "1.11.0", | ||
| "newVersion": "1.11.1", | ||
| "constraints": [ | ||
| { | ||
| "impact": "patch", | ||
| "reason": "Appears in changelog section :bug: Bug Fix" | ||
| } | ||
| ], | ||
| "pkgJSONPath": "/Users/edward/hacking/embroider/packages/util/package.json" | ||
| "oldVersion": "1.11.1" | ||
| }, | ||
| "@embroider/webpack": { | ||
| "oldVersion": "3.0.0" | ||
| } | ||
| }, | ||
| "description": "## Release (2023-06-05)\n\n@embroider/addon-dev 3.1.1 (patch)\n@embroider/compat 3.0.1 (patch)\n@embroider/core 3.0.1 (patch)\n@embroider/router 2.1.1 (patch)\n@embroider/util 1.11.1 (patch)\n\n#### :bug: Bug Fix\n* `compat`\n * [#1460](https://github.com/embroider-build/embroider/pull/1460) expanding EmptyPackage contents ([@ef4](https://github.com/ef4))\n* `addon-dev`\n * [#1423](https://github.com/embroider-build/embroider/pull/1423) Do not write package.json when there are no changes (affects `addon.appReexports()` and `addon.publicAssets()`) ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n * [#1446](https://github.com/embroider-build/embroider/pull/1446) Revert \"Run the clean plugin of addon-dev as late as possible\" ([@mansona](https://github.com/mansona))\n * [#1450](https://github.com/embroider-build/embroider/pull/1450) [bugfix] Ensured that normalizeFileExt ignores .css.d.ts files ([@ijlee2](https://github.com/ijlee2))\n * [#1447](https://github.com/embroider-build/embroider/pull/1447) fix keepAssets corrupting image files ([@mansona](https://github.com/mansona))\n* `compat`, `core`\n * [#1443](https://github.com/embroider-build/embroider/pull/1443) linkto routable engine path in host app ([@void-mAlex](https://github.com/void-mAlex))\n* `addon-dev`, `router`\n * [#1449](https://github.com/embroider-build/embroider/pull/1449) [bugfix] Set output.experimentalMinChunkSize to 0, to counter a change in [email protected] ([@ijlee2](https://github.com/ijlee2))\n* `util`\n * [#1451](https://github.com/embroider-build/embroider/pull/1451) Use `typeof` in `EmbroiderUtilRegistry` ([@bertdeblock](https://github.com/bertdeblock))\n\n#### :memo: Documentation\n* [#1349](https://github.com/embroider-build/embroider/pull/1349) Add a document about pnpm monorepo error ([@mansona](https://github.com/mansona))\n* [#1458](https://github.com/embroider-build/embroider/pull/1458) Add compatible Ember version to README.md ([@EWhite613](https://github.com/EWhite613))\n\n#### :house: Internal\n* [#1444](https://github.com/embroider-build/embroider/pull/1444) clean up patch-package which was introduced with changeset-recover th… ([@void-mAlex](https://github.com/void-mAlex))\n* [#1440](https://github.com/embroider-build/embroider/pull/1440) release preview workflow ([@NullVoxPopuli](https://github.com/NullVoxPopuli))\n\n#### Committers: 7\n- Alex ([@void-mAlex](https://github.com/void-mAlex))\n- Bert De Block ([@bertdeblock](https://github.com/bertdeblock))\n- Chris Manson ([@mansona](https://github.com/mansona))\n- Edward Faulkner ([@ef4](https://github.com/ef4))\n- Eric White ([@EWhite613](https://github.com/EWhite613))\n- Isaac Lee ([@ijlee2](https://github.com/ijlee2))\n- [@NullVoxPopuli](https://github.com/NullVoxPopuli)\n" | ||
| "description": "## Release (2023-06-13)\n\n@embroider/compat 3.0.2 (patch)\n@embroider/core 3.0.2 (patch)\n@embroider/macros 1.11.1 (patch)\n\n#### :bug: Bug Fix\n* `core`\n * [#1463](https://github.com/embroider-build/embroider/pull/1463) fix resolution of files with .hbs extensions ([@ef4](https://github.com/ef4))\n* `macros`\n * [#1468](https://github.com/embroider-build/embroider/pull/1468) macroCondition: do branch elimination if no runtime impl. is involved ([@simonihmig](https://github.com/simonihmig))\n* `compat`\n * [#1412](https://github.com/embroider-build/embroider/pull/1412) WriteV1Config: fix /tests support ([@22a](https://github.com/22a))\n\n#### :house: Internal\n* [#1469](https://github.com/embroider-build/embroider/pull/1469) update deprecated (and removed) blacklist config in test app ([@mansona](https://github.com/mansona))\n\n\n#### Committers: 5\n- Chris Manson ([@mansona](https://github.com/mansona))\n- Edward Faulkner ([@ef4](https://github.com/ef4))\n- Peter Meehan ([@22a](https://github.com/22a))\n- Robert Jackson ([@rwjblue](https://github.com/rwjblue))\n- Simon Ihmig ([@simonihmig](https://github.com/simonihmig))\n" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why include the
pkgJSONPathhere? (since it's machine specific?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually needed, but probably that means we have a bug and right now you need to run
prepareandpublishon the same machine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, repo-root-relative paths could be a fix 😅