Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes case when podModulePrefix is set to my-app/routes #1534

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

evoactivity
Copy link
Contributor

Resolves #1533

I copied the pods scenarios test so this case is explicity tested against. Not sure if that is required.

@evoactivity
Copy link
Contributor Author

evoactivity commented Jul 15, 2023

I didn't realise the test name needed to be hyphenated. Once CI finishes I'll adjust the test.

@ef4 ef4 merged commit ed6910d into embroider-build:main Jul 15, 2023
@ef4
Copy link
Contributor

ef4 commented Jul 15, 2023

Thanks, nice work.

@ef4 ef4 added the bug Something isn't working label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route splitting on pods found under ./app/routes/
2 participants