Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-import-util #1537

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Update babel-import-util #1537

merged 2 commits into from
Jul 15, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jul 15, 2023

This new version of babel-import-util emits imports in a different (better) order, so it's a breaking change that causes us to see some difference in our tests.

(I did this update because I want to control the import order better, so as to be able to keep side-effects in the right order when using importSyncImplementation: 'eager' (the one you need to use with vite.)

This new version of babel-import-util emits imports in a different (better) order, so it's a breaking change that causes us to see some difference in our tests.

(I did this update because I want to control the import order better, so as to be able to keep side-effects in the right order when using `importSyncImplementation: 'eager'` (the one you need to use with vite.)
@ef4 ef4 added the internal label Jul 15, 2023
because it also uses babel-import-util as a transitive dep
@ef4 ef4 merged commit 5fd7c48 into main Jul 15, 2023
@ef4 ef4 deleted the update-import-util branch July 15, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant