Implement the optimizeDeps() helper #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
requested changes
Oct 7, 2023
There was a problem hiding this comment.
I think you need to add a re-export for this so that it can be consumed from a test app like this: https://github.com/embroider-build/embroider/blob/main/packages/vite/index.mjs
On that note I think you should use this function in the actual test app and make sure that it works as expected https://github.com/embroider-build/embroider/blob/main/tests/vite-app/vite.config.mts#L26-L28
|
@mansona Done. |
mansona
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...that can be used in
vite.config.js.It would prevent users from accidentally overriding the important keys (for now it's just
exclude).Comes with the very basic Jest setup, copied from a sibling folder.
Fixes #1621.