Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ts, gts and gjs in vite #1739

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

patricklx
Copy link
Contributor

this adds support for loading ts & gts.

it also adds the gts/gjs extensions to compat-app-builder so that they can be used in tests

NullVoxPopuli added a commit to NullVoxPopuli/polaris-starter that referenced this pull request Dec 21, 2023
@patricklx patricklx force-pushed the vite-other-extensions branch 4 times, most recently from b197170 to 2aaf346 Compare December 22, 2023 10:37
<Fancy @type="primary2"></Fancy>
<Fancy2 @type="primary2"></Fancy2>
`);
await rerender();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking, but rerender isn't needed here

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NullVoxPopuli NullVoxPopuli merged commit 7357b5a into embroider-build:main Dec 22, 2023
205 checks passed
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Dec 22, 2023
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants