Fix fastboot test #1902
Draft
Fix fastboot test #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with embroider-optimized and unskip fastboot test
… resolver, fix the resolution of Fastboot files in Vite module resolver
BlueCutOfficial
force-pushed
the
fix-fastboot-test
branch
from
9f2ee2f
to
c808149
Compare
…-app fixture and consider FORCE_BUILD_TESTS option in the app template
…tests asserting CSS presence
…ecause Rollup doesn't include it
BlueCutOfficial
force-pushed
the
fix-fastboot-test
branch
from
c808149
to
57c2f6b
Compare
BlueCutOfficial
commented
May 23, 2024
| return src; | ||
| if (!macrosConfig) { | ||
| macrosConfig = readJSONSync( | ||
| resolve(locateEmbroiderWorkingDir(process.cwd()), 'rewritten-app', 'macros-config.json') |
There was a problem hiding this comment.
To change after rebase, relates to #1935:
resolve(locateEmbroiderWorkingDir(process.cwd()), 'macros-config.json')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to stop using Fastboot query params: #1900