Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ember engines #1915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update ember engines #1915

wants to merge 2 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented May 14, 2024

No description provided.

SergeAstapov
SergeAstapov previously approved these changes May 14, 2024
@mansona mansona mentioned this pull request May 15, 2024
@mansona mansona dismissed SergeAstapov’s stale review May 15, 2024 11:12

Dismissing until we get tests passing

@mansona
Copy link
Member Author

mansona commented May 15, 2024

@SergeAstapov turns out we weren't testing engines at all on main 🫠 so we should probably make sure tests are passing before we update the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants