Enforce correct plugin order in addon-dev

[simonihmig]

The recent release of addon-dev@v6 was bringing in an undocumented breaking change (which by itself would be ok, since this was a new major) as #2121 required a specific plugin order, where babel has to come last, or at least after hbs and gjs.

The first commit here aligned the plugin order in tests to what we have in the addon-blueprint, where babel comes before hsb and gjs. I think we should keep these in sync, as that would have uncovered the breaking change!

After that change, you can see here how the babel plugin fails to parse the (untransformed) gjs file. Same happens in the PR to update deps in the addon-blueprint: embroider-build/addon-blueprint#299

We could tell users to change the plugin order, but that causes a lot of churn, as basically every v2 addon out there has the order as in the blueprint. And I think ideally from DX perspective would be good if the order didn't matter to users.

This PR enforces the hbs and gjs plugins to run before others (including babel).

Btw, for the hbs plugin, I believe this shouldn't really be needed in 99%+ of cases, only when you have hbs transforms registered via babel-plugin-ember-template-compilation, which we had in our tests.

[patricklx]

I think babel must be the last. whats the issue with the order?

[patricklx]

ah, I see, thats how the blueprint is.
But the recent PR changed hbs & gjs plugins to use transform hook. So the order of the blueprint must be changed.
the tests in embroider were already at correct order before the change... I wonder why it wasnt the same order in the blueprint

[patricklx]

looks like the PR i did was more of a breaking change then?
ah, but it was included into a breaking release anyway.

[simonihmig]

Yeah, exactly. It should have at least a notice on the breaking change in the changelog. But I think it could be fixed maybe, trying this out in this draft PR! Will ping you once I'm ready.

[patricklx]

well, the blueprint should really have the babel plugin as last.

[simonihmig]

@patricklx ready to go now, see the PR description!

well, the blueprint should really have the babel plugin as last.

We can still decide to make that change in the blueprint if we feel this is the safer path forward. But the change in this PR makes this optional, which I think is better than forcing this on users by running into build errors...

[simonihmig]

Weird, beta tests (Ember 6) are failing here with Components with separately resolved templates were removed at Ember 6.0. Migrate to either co-located js/ts + hbs files or to gjs/gts., while they are passing for canary, and last scheduled job is also passing. But the changes here cannot have caused this (these are app tests), right? 🤔

[ef4]

Canary is not really the current canary. #2073

[simonihmig]

while they are passing for canary, and last scheduled job is also passing

nvm, the passing scheduled job was for main. There was a previous failing build on stable before, so this is an issue we have on stable, and not related to this PR!