error instead of warn for missing exports #2157
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this:
will cause Webpack to warn if
foo
does not exist, but this is easily missed. Meaning its possible to ship broken code.This PR configures
strictExportPresence
to error instead of warn.But this is actually deprecated in favour of
exportsPresence
, which I did try but it wasn't available on the current version.Also note it will be true by default in v6 of webpack anyway.
Reading:
Regarding tests, since I'm not familiar with the embroider repo I found it hard to know where they should go. I saw some that seemed like an appropriate place, but I'll need help tbh.