Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated macro system #344

Merged
merged 24 commits into from
Feb 26, 2020
Merged

Updated macro system #344

merged 24 commits into from
Feb 26, 2020

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Oct 22, 2019

This is bringing @embroider/macros up to date with RFC 507.

Here's a table to track progress.

  • "implemented macro" means that the build-time implementation is done and matches the RFC. Some of the unchecked ones may have implementations but need review to compare against the latest RFC
  • "implemented types & runtime" means that the run-time implementation is done and matches the RFC. This also provides the typescript types that users of the macros will see.
  • "documented" means it's documented in this package's README. Some of the unchecked ones may already be documented but need another review pass to ensure they match the latest.
name type implemented macro implemented types & runtime documented
dependencySatisfies js ✔️
hbs
each js ✔️
hbs
failBuild js ✔️
hbs
getConfig js ✔️
hbs
getOwnConfig js ✔️
hbs
importSync js ✔️
hbs
macroCondition js ✔️
hbs
moduleExists js ✔️
hbs
maybeAttrs js not applicable not applicable not applicable
hbs

@simonihmig
Copy link
Collaborator

@ef4 any ETA for this?

Sorry for being impatient here :) But we are just closing down on a major refactoring of ember-bootstrap's build system, from having separate trees and broccoli magic to (eventually build-time) helpers (context: ember-bootstrap/ember-bootstrap#984). The initial plan was to provide our own AST transforms (much narrower scope). But having learned that these macros here also work for classic ember-cli addons, it makes these a perfect fit, and certainly a better choice than to reinvent the wheel.

However I wouldn't want to be blocked for too long, that's why I'm asking! :)

Just from a quick look it seems that the glimmer transforms are not updated yet, right?

Maybe I can help bring this over the finish line! Could you provide me a gist of what's still missing, with any context that I might need?

@ef4 ef4 marked this pull request as ready for review February 26, 2020 22:31
@ef4
Copy link
Contributor Author

ef4 commented Feb 26, 2020

Merging this because there's no need to a long-lived branch. I'll copy the remaining todo into a separate issue.

@ef4 ef4 merged commit 0dea244 into master Feb 26, 2020
@ef4 ef4 deleted the better-macros branch February 26, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants