Run importSync transform later, so ember-auto-import can support importSync #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated canary failures here... |
|
@ef4 can we merge this? |
|
@simonihmig the canary failures have been fixed, mind rebasing? |
rwjblue
approved these changes
Mar 2, 2021
…rtSync This runs the transform of importSync in the exit hook, to allow ember-auto-import to do its own transformation *before* us. See embroider-build/ember-auto-import#347
simonihmig
force-pushed
the
import-sync-later
branch
from
407aabd
to
0a3a148
Compare
Done, green now! Thanks for the review! |
This was referenced Mar 2, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the transform of importSync in the exit hook, to allow ember-auto-import to do its own transformation before us. See embroider-build/ember-auto-import#347