Add better support for skipping Stage 1 transforms that are not needed #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds filtering for a newer stock plugin added by ember-cli-htmlbars. Next we need to also do this filtering before counting the present plugins in `needsCustomBabel` to skip it entirely.
Because some addons call ember-cli-babel directly (boo!), which thankfully we already have test coverage for (yay!).
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds filtering for a newer stock plugin added by ember-cli-htmlbars, and ensures that filtered babel plugins don't trigger custom transpilation at stage1.