-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage test-scenarios from ember-auto-import #756
Conversation
This will eventually get expanded to a matrix when #756 lands, but I need to test some newer stuff now.
Thank you for fighting the good fight here. |
a33a6fd
to
d463ea5
Compare
We had same problem for LS, and recently I spend some time on project serialization optimization, and now project could be stored as json file https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/test/fixtures/batman/project.json found it's quite useful. toObject normalizer for this format (https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/test/test_helpers/integration-helpers.ts#L114) serializer to flat format: https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/test/test_helpers/integration-helpers.ts#L55 |
Ok this should be good to go now. The node_modules hoisting issue was just a bad yarn.lock (so I don't need to do the yarn hack). I also had to add This only adds release as scenarios so we can discuss what the full matrix should look like. Additionally, an improvement to |
Thanks, looking good.
Yeah the closest example is this plus this which lets you multiply out the scenarios, but not bake the environment variables right into the scenarios themselves. |
Problem
Currently our test suite is setup that each test package is an actual ember application (or addon). While this works, we incur a large overhead in maintenance, dryness, and complexity.
Solution
Instead of individual packages that are full blown applications, we can leverage a shared base "template" that we apply diffs on top. This base template can be maintained via ember-cli-update while all of the test scenarios don't need to care about the underlining template.
Future
This PR simply converts the
fastboot-app
test package over to the new format. Once this lands all the rest of the test pacakges can be converted one by one.