-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace loader-utils with built-in webpack 5 functionality #831
Conversation
e57d3ae
to
98fe177
Compare
I rebased on latest master. |
Kicked off CI |
98fe177
to
a7663a4
Compare
e45c04c
to
48f47f7
Compare
We can't just remove the types. We currently use @mydea would you like to work on that? |
I think you can also address this while you are there. It seems like recent versions of webpack does have a type for |
I will give it a try! |
Hmm, does hbs-loader need to remain compatible with webpack 4? Meaning, do I need to build this in a way that it either uses the new webpack loader, or I would go with the latter ( |
48f47f7
to
f6b1c9c
Compare
@types/loader-utils
dependency
I updated the PR to update webpack peerDependency to 5 for hbs-loader, and replace loader-utils with the built-in functionality & the new types. |
Thanks! |
This was changed in embroider-build#831, but in the meanwhile also added here.
Webpack has built-in types now, which seem to conflict with
@types/loader-utils
. I think we can just remove this dependency - see webpack/loader-utils#179.Fixes #819