Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with [email protected]+ #880

Merged
merged 5 commits into from
Jul 30, 2021
Merged

Fix compatibility with [email protected]+ #880

merged 5 commits into from
Jul 30, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jun 28, 2021

ember-data really needs to stop running its own complicated build-within-the-build and move these customized steps to prepublish (if they're truly needed at all, which I am skeptical about).

Todo:

  • check this against other recent ember-data versions to make sure we're not simlutaneously breaking them.

@ef4
Copy link
Contributor Author

ef4 commented Jun 29, 2021

This fixes #826

@rwjblue
Copy link
Collaborator

rwjblue commented Jun 29, 2021

ember-data really needs to stop running its own complicated build-within-the-build and move these customized steps to prepublish

Ya, we are working on it (had a bunch of discussions over in the recent ember-data core calls).

@rwjblue rwjblue added the bug Something isn't working label Jun 29, 2021
@rwjblue rwjblue changed the title Updating ember-data compat adapters Fix compatibility with [email protected]+ Jun 29, 2021
@thoov
Copy link
Collaborator

thoov commented Jun 29, 2021

check this against other recent ember-data versions to make sure we're not simlutaneously breaking them

Can you add ember-data to scenarios.ts such that we can get coverage back to 3.16?

@ef4 ef4 merged commit ed059fd into master Jul 30, 2021
@ef4 ef4 deleted the ember-data-compat branch July 30, 2021 01:01
@stefanpenner
Copy link
Collaborator

I don't believe this PR works as expected, see: #946

@stefanpenner
Copy link
Collaborator

Never mind, I was using an older version of embroider in my tests. As of [email protected] the problem is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants