Fix arguments to preprocessCss (to match classic build)
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jul 28, 2021
|
CI is now back to normal, the remaining failures here are real failures, I think. |
asakusuma
reviewed
Jul 30, 2021
In classic builds the second argument is '/app/styles' but we were passing 'app/styles'. While this difference might be small, in ember-cli-eyeglass [it removes the leading slash](https://github.com/linkedin/eyeglass/blob/master/packages/ember-cli-eyeglass/src/index.ts#L210-L212) and this causes issues when the slash is missing.
thoov
force-pushed
the
preprocess-argument-fix
branch
from
34d7f4f
to
5083212
Compare
|
@rwjblue This should be good to go |
rwjblue
changed the title
preprocessCss (to match classic build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In classic builds the second argument is '/app/styles' but we were passing 'app/styles'. While this difference might be small, in
ember-cli-eyeglass it removes the leading slash and this causes issues when the slash is missing. This PR aligns with what classic was doing along with adding a very simple test case.
Fixes: #908