Robustly discover packages for any tool #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Jan 11, 2024
src/configuration.ts
Outdated
| } | ||
|
|
||
| function getPackages(rootPath: string): { name: string; path: string }[] { | ||
| let { packages } = getPackagesSync(rootPath) as PackagesResult; |
There was a problem hiding this comment.
I couldn't find types for manypkg, so I just made a rough minimal set, based on what I was seeing as output
NullVoxPopuli
commented
Jan 11, 2024
| type: 'pnpm' | 'yarn' | 'npm'; | ||
| }; | ||
| packages: Package[] | ||
| rootPackage: Package; |
There was a problem hiding this comment.
the rootPackage is included in packages, so this is what will allow release-plan to work for single-package monorepos (or monorepos with nested workspaces, like https://github.com/universal-ember/kolay/).
NullVoxPopuli
changed the title
NullVoxPopuli
added a commit
to NullVoxPopuli/ember-resources
that referenced
this pull request
Jan 11, 2024
NullVoxPopuli
added a commit
to NullVoxPopuli/ember-resources
that referenced
this pull request
Jan 11, 2024
…r-release-plan Use fix for release-plan from: embroider-build/github-changelog#8
mansona
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manypkg gets all packages, including the root workspace.
This means release-plan does not need to care about the "singlePackage" thing and that code can be removed.
(tho, release-plan will probably need a similar change)
Can test on your own repo with an override: